Hi Jim, Thanks for the message. Glad to be able to give something back - you chaps have collectively helped me out on numerous occasions, knowingly or not.
Here's the patch as the output of "cvs diff". I've tried to restrict the changes to as
small a region of source as possible. If someone wanted to integrate the language
check into the version number check towards the top of the function that would be
slightly more efficient, and possibly a little neater too.
Hope people find this useful. Feel free to pass on any feedback - positive or
otherwise!
Cheers,
Simon
-----Original Message-----
From: [EMAIL PROTECTED]
To: Simon Protheroe; [EMAIL PROTECTED]
Sent: 07/11/2003 17:56
Subject: RE: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification warnings
Cool... just send a patch to the list, and someone will patch the cvs
version.
Thanks for the update
Jim
_____
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Simon Protheroe
Sent: Friday, November 07, 2003 6:48 AM
To: [EMAIL PROTECTED]
Subject: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification
warnings
Hi,
I've modified the MSITask to include a valid language field for entries
in the File table generated by the <component> tag. It's a very simple
(probably too simple!) change with a single new block of around 8 LOC
and a minor change to an existing line. The resulting task generates MSI
files that don't trigger ICE verification warnings from Orca, MSIVer2
etc.
As I'm new to SourceForge, could someone tell me how I should submit the
changes - in what format, where etc?
Regards,
Simon
MSITask.cs.diff
Description: MSITask.cs.diff
