Right, both tasks are very similar... the problem is that they use schemas to define the objects used in the task, making both schemas just slightly different. It would be nice to have a shared installer base and then have the separate tasks use that base. I don't think I have the time to do this, but if you or Simon wants to tackle it, I'd be happy to answer questions as they arise...
Also, another thing that comes up do to the tasks using the schema method, is that documentation support is not there. It would be nice to have these tasks support xml task documentation like all other NAnt tasks. This might have more to do with the xsd task though. Jim -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gert Driesen Sent: Monday, November 10, 2003 4:42 AM To: James Geurts; 'Simon Protheroe'; [EMAIL PROTECTED] Subject: Re: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification warnings James, I've committed your patch to cvs. But as it seems both tasks could do with some refactoring as both share quite some code. Can either of you have a look at this or should I put it on my to-do list ? Thanks, Gert ----- Original Message ----- From: "James Geurts" <[EMAIL PROTECTED]> To: "'Simon Protheroe'" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, November 09, 2003 11:05 PM Subject: RE: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification warnings > To keep both the msm and msi tasks in a similar state, I've included the > same patch for the MSMTask also. > > Jim > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Simon Protheroe > Sent: Friday, November 07, 2003 5:17 PM > To: [EMAIL PROTECTED] > Subject: RE: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification > warnings > > > Hi Jim, > > Thanks for the message. Glad to be able to give something back - you chaps > have collectively helped me out on numerous occasions, knowingly or not. > > Here's the patch as the output of "cvs diff". I've tried to restrict the > changes to as small a region of source as possible. If someone wanted to > integrate the language check into the version number check towards the top > of the function that would be slightly more efficient, and possibly a little > neater too. > > Hope people find this useful. Feel free to pass on any feedback - positive > or otherwise! > > Cheers, > Simon > > -----Original Message----- > From: [EMAIL PROTECTED] > To: Simon Protheroe; [EMAIL PROTECTED] > Sent: 07/11/2003 17:56 > Subject: RE: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification > warnings > > Cool... just send a patch to the list, and someone will patch the cvs > version. > > > > Thanks for the update > > > > Jim > > > > _____ > > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Simon Protheroe > Sent: Friday, November 07, 2003 6:48 AM > To: [EMAIL PROTECTED] > Subject: [NAntC-Dev] Patch for MSITask to avoid Orca ICE60 verification > warnings > > > > Hi, > > > > I've modified the MSITask to include a valid language field for entries > in the File table generated by the <component> tag. It's a very simple > (probably too simple!) change with a single new block of around 8 LOC > and a minor change to an existing line. The resulting task generates MSI > files that don't trigger ICE verification warnings from Orca, MSIVer2 > etc. > > > > As I'm new to SourceForge, could someone tell me how I should submit the > changes - in what format, where etc? > > > > Regards, > > Simon > > ------------------------------------------------------- This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer ------------------------------------------------------- This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ NAntContrib-Developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
