On 10/18/2016 06:01 AM, Wouter Verhelst wrote:

>> Following the advice almost works, except that automake 1.15 still
>> has a nasty bug (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13928)
>> where use of $(foo) in a _SOURCES variable coupled with subdir-objects
>> creates a directory with a literal name $(foo) rather than the intended
>> name.  But as long as we only care about $(srcdir) (or parent
>> directories), the solution is to just not use $(srcdir) in _SOURCES,
>> and instead open-code the traversal to the desired files.
> 
> The reason for using $(top_srcdir) is so that VPATH builds don't go
> bollocks. Did you do a "make distcheck" with this?

Not yet; will do and report back.

> 
> Also, did you check that this doesn't break on older automake versions?
> (not critical, but I just recently cherry-picked two commits from Josef
> to allow building on CentOS 6, would be silly if we lose that again...)

And that will be part of my testing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Nbd-general mailing list
Nbd-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nbd-general

Reply via email to