On Tue, Oct 18, 2016 at 04:55:48PM +0100, Alex Bligh wrote: > > > On 18 Oct 2016, at 15:19, Eric Blake <[email protected]> wrote: > > > > Initial testing: broken before my patches: > > > > checking for GnuTLS... configure: error: Package requirements (gnutls >= > > 3.3.0) were not met: > > > > Requested 'gnutls >= 3.3.0' but version of GnuTLS is 2.8.5 > > > > You'll want to make the new TLS code conditional, and merely disable TLS > > rather than fail the entire build if you don't have a new enough library > > to rely on. I might be able to develop that patch too... > > I don't think we should require gnutls >= 3.3.0 > > My patches (for both the server and client) worked with an older versions > of gnutls deliberately (certainly whatever ships with Ubuntu 14.04, which > I think is 2.12.23). > > Is there any reason to depend on such a new version of gnutls?
older versions require gnutls_init(), as of 3.3.0 that isn't required. I thought 3.3.0 was sufficiently old that this wouldn't be a problem, but I guess that that's wrong and I should revisit it. > I seem to remember that one tiny bit of set up took slightly more > calls on old versions. Indeed :-) > My branch is at: > https://github.com/abligh/nbd/tree/add-tls-support > > if you want to nick the TLS code (including autotools etc support) I was planning to look at it. I certainly wanted to get your client-side TLS support patches, since we do need a proxy there, and that's what you implemented. -- < ron> I mean, the main *practical* problem with C++, is there's like a dozen people in the world who think they really understand all of its rules, and pretty much all of them are just lying to themselves too. -- #debian-devel, OFTC, 2016-02-12 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
