Hi, sorry, I wasn't aware of your contribution. I didn't check all the open tickets regarding Gantt.
Personally I would prefer an update of your patch to the ticket. I haven't worked with Gerrit yet. Sure I need to do so soon, but an updated patch would be easier for the moment. :) Regarding your enhancement of the holiday feature, does the old style without names still work then? In that case feel free to create a new ticket and attach the corresponding patch. I will try to check and apply them as soon as I find the time for it. Greez, Dirk P.S. It's always great to get contributions. We simply sometimes do not notice or forget them. So reminding us via mailing list is a good idea. :) On Thu, Nov 7, 2013 at 11:03 AM, Hermsdorf, Peter <[email protected] > wrote: > hi, > > some time ago i opened bug > https://bugs.eclipse.org/bugs/show_bug.cgi?id=353506 and supplied a patch. > > The Bug is about the calculation of the horizontal scrolling, the size of > the scrollbar and that it was possible to leave the scroll range under > certain circumstances. > > After the recent contributions of Dirk Fauth (including support for > holidays) i reapplied my changes to the current eclipse git codebase and > they still seem to work. > > Would an updated patch to my bug report be considered to be integrated in > the code base? > > Should i update the patch on the bug report or contribute via Gerrit/Git > as stated in the Contributor Guide? > > Additionally i have extended the holiday feature to support tooltips with > the names of the holidays. I am willing to create a new bug and supply a > patch if there is interest in that functionality. > > Greets, > Peter > _______________________________________________ > nebula-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/nebula-dev >
_______________________________________________ nebula-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/nebula-dev
