Hi Dirk, just pushed patch for the holiday tooltips. Can you check if you see them in gerrit?
________________________________ Von: [email protected] [[email protected]]" im Auftrag von "Dirk Fauth [[email protected]] Gesendet: Donnerstag, 7. November 2013 13:41 An: Nebula Dev Betreff: Re: [nebula-dev] Gantt updated patch - how to contribute Ok, so I wait until I get notice from Gerrit about the contribution from Peter Hermsdorf. The Skype request is coming shortly. ;) On Thu, Nov 7, 2013 at 1:31 PM, Mickael Istria <[email protected]<mailto:[email protected]>> wrote: On 11/07/2013 01:21 PM, Dirk Fauth wrote: Does the contributor need to start the process by contributing, or do I need to start something? With the Gerrit process, you don't need to do anything except reviewing the patch. Then you give a note about: * Code review: does code look good enough? * Verified: does it work? * IP: are copyright headers and so on conforming to Eclipse requirements? When you have given a positive vote to this 3 criteria, you can click on the "Submit" button and the patch will get merged. For older commits, there is a "rebase" button that rebases them on top of HEAD. In case of conflict while rebasing, you can either ask the contributor to do the rebase locally and push a newer version of the patch, or do it yourself locally and push a newer version of the patch (they will appear as versions as long as commits have the same change-id). -- Mickael Istria Eclipse developer at JBoss, by Red Hat<http://www.jboss.org/tools> My blog<http://mickaelistria.wordpress.com> - My Tweets<http://twitter.com/mickaelistria> _______________________________________________ nebula-dev mailing list [email protected]<mailto:[email protected]> https://dev.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________ nebula-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/nebula-dev
