----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101856/#review4483 -----------------------------------------------------------
nepomuk/services/storage/lib/simpleresource.h <http://git.reviewboard.kde.org/r/101856/#comment3798> Why not use member methods instead of friend declarations? nepomuk/services/storage/lib/simpleresourcegraph.h <http://git.reviewboard.kde.org/r/101856/#comment3794> How about operator+ and operator+= instead? nepomuk/services/storage/lib/simpleresourcegraph.h <http://git.reviewboard.kde.org/r/101856/#comment3795> If you need friend decarations then why don't you make the operators member methods? nepomuk/services/storage/lib/simpleresourcegraph.cpp <http://git.reviewboard.kde.org/r/101856/#comment3796> Please do not use "this" when not required. nepomuk/services/storage/lib/simpleresourcegraph.cpp <http://git.reviewboard.kde.org/r/101856/#comment3797> Why not fit->addProperties(...)? - Sebastian On July 6, 2011, 10:01 p.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101856/ > ----------------------------------------------------------- > > (Updated July 6, 2011, 10:01 p.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Extra functions to SimpleResource|Graph > 1. Operator comparison for Graph > 2. addGraph for Graph - merges 2 graphs into one > 3. Serialization operators to QDataStream to both classes. > 4. Tests for simpleresourcetest > > > Diffs > ----- > > nepomuk/services/storage/lib/simpleresource.h c6c3b04 > nepomuk/services/storage/lib/simpleresource.cpp 3d529bb > nepomuk/services/storage/lib/simpleresourcegraph.h 6a3a0ee > nepomuk/services/storage/lib/simpleresourcegraph.cpp 419a949 > nepomuk/services/storage/test/CMakeLists.txt f8d00de > nepomuk/services/storage/test/simpleresourceclassestest.h PRE-CREATION > nepomuk/services/storage/test/simpleresourceclassestest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101856/diff > > > Testing > ------- > > Provide tests for this operations. Currently failing addGraph test, because > of SimpleResource::addProperties behaviour. But may be it is intended, then I > will rewrite test case. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
