> On July 7, 2011, 7:59 a.m., Sebastian Trueg wrote: > > nepomuk/services/storage/lib/simpleresource.h, line 171 > > <http://git.reviewboard.kde.org/r/101856/diff/2/?file=26197#file26197line171> > > > > Why not use member methods instead of friend declarations? > > Artem Serebriyskiy wrote: > Hm. operator<< can't be overloaded this way. It can be made a member of > QDataStream, but I doubt Qt developres will allow me this.
right. > On July 7, 2011, 7:59 a.m., Sebastian Trueg wrote: > > nepomuk/services/storage/lib/simpleresourcegraph.h, line 106 > > <http://git.reviewboard.kde.org/r/101856/diff/2/?file=26199#file26199line106> > > > > If you need friend decarations then why don't you make the operators > > member methods? > > Artem Serebriyskiy wrote: > Usually, it is recomended(as guidlines) to overload operators for > ?ommutative operations ( +, ==, != ) as non-mebers. I can change it, if you > insist. I don't insist, it just seems simpler and cleaner if you need access to internal members. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101856/#review4483 ----------------------------------------------------------- On July 7, 2011, 8:44 a.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101856/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 8:44 a.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Extra functions to SimpleResource|Graph > 1. Operator comparison for Graph > 2. addGraph for Graph - merges 2 graphs into one > 3. Serialization operators to QDataStream to both classes. > 4. Tests for simpleresourcetest > > > Diffs > ----- > > nepomuk/services/storage/lib/simpleresource.h c6c3b04 > nepomuk/services/storage/lib/simpleresource.cpp 3d529bb > nepomuk/services/storage/lib/simpleresourcegraph.h 6a3a0ee > nepomuk/services/storage/lib/simpleresourcegraph.cpp 419a949 > nepomuk/services/storage/test/CMakeLists.txt f8d00de > nepomuk/services/storage/test/simpleresourceclassestest.h PRE-CREATION > nepomuk/services/storage/test/simpleresourceclassestest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101856/diff > > > Testing > ------- > > Provide tests for this operations. Currently failing addGraph test, because > of SimpleResource::addProperties behaviour. But may be it is intended, then I > will rewrite test case. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
