----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101856/#review4492 -----------------------------------------------------------
nepomuk/services/storage/lib/simpleresource.h <http://git.reviewboard.kde.org/r/101856/#comment3808> Please add one empty line after the friend declarations. nepomuk/services/storage/lib/simpleresourcegraph.h <http://git.reviewboard.kde.org/r/101856/#comment3809> Nitpicking: missing empty line again. nepomuk/services/storage/lib/simpleresourcegraph.h <http://git.reviewboard.kde.org/r/101856/#comment3811> Actually I think comparison operators would be much cleaner as members. To me friend declarations always feel ugly. nepomuk/services/storage/lib/simpleresourcegraph.h <http://git.reviewboard.kde.org/r/101856/#comment3810> and one more empty line missing. nepomuk/services/storage/lib/simpleresourcegraph.cpp <http://git.reviewboard.kde.org/r/101856/#comment3812> Why not use graph.toList() and avoid the need of making it a friend? Also storing a list is sufficient since the URIs are contained in the SimpleResources anyway. - Sebastian On July 7, 2011, 8:44 a.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101856/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 8:44 a.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Extra functions to SimpleResource|Graph > 1. Operator comparison for Graph > 2. addGraph for Graph - merges 2 graphs into one > 3. Serialization operators to QDataStream to both classes. > 4. Tests for simpleresourcetest > > > Diffs > ----- > > nepomuk/services/storage/lib/simpleresource.h c6c3b04 > nepomuk/services/storage/lib/simpleresource.cpp 3d529bb > nepomuk/services/storage/lib/simpleresourcegraph.h 6a3a0ee > nepomuk/services/storage/lib/simpleresourcegraph.cpp 419a949 > nepomuk/services/storage/test/CMakeLists.txt f8d00de > nepomuk/services/storage/test/simpleresourceclassestest.h PRE-CREATION > nepomuk/services/storage/test/simpleresourceclassestest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101856/diff > > > Testing > ------- > > Provide tests for this operations. Currently failing addGraph test, because > of SimpleResource::addProperties behaviour. But may be it is intended, then I > will rewrite test case. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
