On Wed, 20 Jan 2021 15:46:13 GMT, Eirik Bjørsnøs <github.com+300291+eir...@openjdk.org> wrote:
>> By moving string splitting and concatenation into the canonizeString >> utility, we can defer allocation until we determine that canonization is >> required. This saves two string allocations and a string concat for the >> common case where canonization is not required. >> >> As a refactoring, move ParseUtil.canonizeString/doCanonize into Handler >> since that's the only call site. >> >> Finally, let's rename the method to canonizalizeString, since canonization >> is an rather unrelated term. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > As a part of the rename from "canonize" to "canonicalize", doCanonize > should also be renamed. This was an oversight in the original PR. Looks good to me. ------------- Marked as reviewed by chegar (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2167
