On Thu, 21 Jan 2021 09:48:50 GMT, Chris Hegarty <che...@openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   As a part of the rename from "canonize" to "canonicalize", doCanonize 
>> should also be renamed. This was an oversight in the original PR.
>
> Looks good to me.

> Newbie question: Is a copyright year updates required when code is simply 
> moved around like this?
> 
> More specifically, is it required when strictly deleting code from a file, 
> like ParseUtil in this case?

I would prefer if the copyright year range was updated in these files - this is 
a non-trivial change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2167

Reply via email to