On Thu, 21 Jan 2021 10:11:11 GMT, Eirik Bjorsnos 
<github.com+300291+eir...@openjdk.org> wrote:

>> By moving string splitting and concatenation into the canonizeString 
>> utility, we can defer allocation until we determine that canonization is 
>> required. This saves two string allocations and a string concat for the 
>> common case where canonization is not required.
>> 
>> As a refactoring, move ParseUtil.canonizeString/doCanonize into Handler 
>> since that's the only call site.
>> 
>> Finally, let's rename the method to canonizalizeString, since canonization 
>> is an rather unrelated term.
>
> Eirik Bjorsnos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year in affected files since the change is non-trivial

Looks good. (You need to cast /integrate again for us to be able to /sponsor)

-------------

Marked as reviewed by redestad (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2167

Reply via email to