On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs <[email protected]> wrote:
> The HttpClient internal DebugLogger could be simplified if its configuration
> was held in a record. Some of the methods in Utils that return a debug logger
> could also be simplified/removed. The system property that configures the
> debug logging could be extended to choose between System.err, System.out,
> System.Logger, or any of these configurations.
> Passing -Djdk.internal.httpclient.debug=true still works as before.
src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java
line 59:
> 57: * printed to {@link System#err}
> 58: * @param logLevel the level above which messages will be forwarded
> 59: * to an underlying {@link System.Logger}
Hello Daniel, looking at the code, it appears to me that the documentation of
all these three levels should say "the level above or equal to which ..." (i.e.
`>=` instead of `>`).
-------------
PR: https://git.openjdk.org/jdk/pull/12900
