On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs <[email protected]> wrote:
> The HttpClient internal DebugLogger could be simplified if its configuration
> was held in a record. Some of the methods in Utils that return a debug logger
> could also be simplified/removed. The system property that configures the
> debug logging could be extended to choose between System.err, System.out,
> System.Logger, or any of these configurations.
> Passing -Djdk.internal.httpclient.debug=true still works as before.
src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java
line 70:
> 68: // true if at least on of the three levels is not Level.OFF
> 69: public boolean on() {
> 70: return minSeverity() <= Level.OFF.getSeverity();
I suspect this should instead be `return minSeverity() <
Level.OFF.getSeverity();` i.e. if min severity if `OFF` then on() shouldn't
return `true`.
-------------
PR: https://git.openjdk.org/jdk/pull/12900
