On Fri, 1 Nov 2024 22:34:46 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test >> described >> [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) >> to the networking area modules. >> >> The benefit from this is helping API authors and reviewer validate the >> accuracy of `@since` in their source code (and subsequently, in the >> generated documentation). >> >> The test has been added for `java.base` 2 weeks ago and has helped catch >> some bugs before they make it to the JDK. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > make jtreg comment more concise I originally added the underscores because naming a directory `java.base` caused some issues, but I can't reproduce that problem now so let's remove them. I'd like the file with the `jtreg` comment to have a unique/searchable name because we want to eventually have a test for every module, I think both options you mentioned are possible. Would `tools/sincechecker/modules/javaNetHttp.java`, `tools/sincechecker/modules/jdkNet.java` etc... work? Or `..modules/javaNetHttpSinceCheck.java` ------------- PR Comment: https://git.openjdk.org/jdk/pull/21838#issuecomment-2453465433
