On Mon, 4 Nov 2024 18:28:00 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test >> described >> [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) >> to the networking area modules. >> >> The benefit from this is helping API authors and reviewer validate the >> accuracy of `@since` in their source code (and subsequently, in the >> generated documentation). >> >> The test has been added for `java.base` 2 weeks ago and has helped catch >> some bugs before they make it to the JDK. >> >> Note: the `@modules` declarations are missing from the jtreg comment because >> we will now include them in a `TEST.properties` file. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Rename tests and directories under modules dir Looks good - but you will need to create the TEST.properties file with the appropiate `@modules` before integrating. When I import this PR into my repo and run `jtreg tools/sincechecker/modules/java.net.http/` the test fails to compile due to: test/jdk/tools/sincechecker/SinceChecker.java:44: error: package com.sun.tools.javac.api is not visible import com.sun.tools.javac.api.JavacTaskImpl; ^ (package com.sun.tools.javac.api is declared in module jdk.compiler, which does not export it to the unnamed module) ------------- PR Review: https://git.openjdk.org/jdk/pull/21838#pullrequestreview-2415832378
