On Mon, 4 Nov 2024 18:28:00 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test >> described >> [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) >> to the networking area modules. >> >> The benefit from this is helping API authors and reviewer validate the >> accuracy of `@since` in their source code (and subsequently, in the >> generated documentation). >> >> The test has been added for `java.base` 2 weeks ago and has helped catch >> some bugs before they make it to the JDK. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Rename tests and directories under modules dir Thank you for the update, Nizar. This now looks good to me. For my own reference - it looks like these tests will run in `tier3`. Although we don't have a 2 reviewer rule in this area, it would be good to have at least one more review for this change before it's integrated. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21838#pullrequestreview-2414509397
