On Wed, 13 Nov 2024 10:40:25 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
>> line 434:
>>
>>> 432: * The response is always returned with fixed length.
>>> 433: */
>>> 434: public static class HttpHeadHandler implements HttpTestHandler {
>>
>> The class name is slightly misleading since this also handles `GET`. Perhaps
>> `HeadOrGetHandler` would be appropriate?
>
> And maybe we should make this a top level public class in this test package
> to reduce the amount of code we have in the `HttpServerAdapters` file.
Renamed HttpHeadOrGetHandler. I'd rather keep the implementation in this file.
We already have an HttpEchoHandler here, and there are two many classes bearing
this name in the test class hierarchy to consider making it top level.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21991#discussion_r1840437229
