On Wed, 13 Nov 2024 10:23:44 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test/jdk/java/net/httpclient/http2/StreamFlowControlTest.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 1594:
>
>> 1592: Log.logError(ex);
>> 1593: } finally {
>> 1594: drainInputQueue();
>
> Hello Daniel, now that the `cancelImpl(...)` itself drains the queue in a
> `finally` block, do you think we should remove the call to
> `drainInputQueue()` from the finally block of `schedule()` after we call
> `cancelImpl(...)` there?
Good point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21991#discussion_r1840464102
