On Wed, 13 Nov 2024 14:41:11 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> OutputStream::close is supposed to be idempotent and I do believe it is in >> this implementation. It would be a bug if `getResponseBody().close()` were >> not. I have followed your suggestion though. > >> It would be a bug if getResponseBody().close() were not. > > Sorry, my comment wasn't clear. What I meant was, I think a second call to > `getResponseBody()` (in theory) could throw an exception if `close()` has > already been called on the `OutputStream` returned by the previous call to > `getResponseBody()`. Oh - thanks yes. Should be good now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21991#discussion_r1840485732
