Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v12]

[Mark Sheppard]

On Thu, 21 Nov 2024 10:47:54 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close 
>> the `Socket` in the event that the connection cannot be established, the 
>> timeout expires before the connection is established, or the socket address 
>> is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handle `SocketTimeoutException` in `NioSocketImpl::connect()`

test/jdk/java/net/Socket/CloseOnFailureTest.java line 149:

> 147: 
> 148:     }
> 149: 

static List<TestCase> ctorCloseOnFailuresTestCases() {
         return List.of(
                 TestCase.BindFailureFactory.ioExceptionTestCase(),
                 TestCase.ConnectFailureFactory.ioExceptionTestCase(),
                 
TestCase.ConnectFailureFactory.illegalArgumentExceptionTestCase(1));
     }

c.f. name change suggestion below

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1852967269