On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close >> the `Socket` in the event that the connection cannot be established, the >> timeout expires before the connection is established, or the socket address >> is unresolved. >> >> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2. > > Volkan Yazıcı has updated the pull request incrementally with one additional > commit since the last revision: > > Improve naming in tests test/jdk/java/net/Socket/CloseOnFailureTest.java line 59: > 57: > 58: private static final VarHandle SOCKET_IMPL_FACTORY_HANDLE = > createSocketImplFactoryHandle(); > 59: private static final int DEADSERVERPORT = 0xDEAD; test/jdk/java/net/Socket/CloseOnFailureTest.java line 140: > 138: InetAddress serverAddress = > InetAddress.getLoopbackAddress(); > 139: int deadServerPort = 0xDEAD; > 140: new Socket(serverAddress, deadServerPort, null, 0); new Socket(serverAddress, DEADSERVERPORT, null, 0); // DEADSERVERPORT declared as a constant above ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1854661216 PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1854661142
