Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v13]

[Mark Sheppard]

On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close 
>> the `Socket` in the event that the connection cannot be established, the 
>> timeout expires before the connection is established, or the socket address 
>> is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Improve naming in tests

test/jdk/java/net/Socket/CloseOnFailureTest.java line 84:

> 82: 
> 83:         private final AtomicInteger closeInvocationCounter = new 
> AtomicInteger(0);
> 84: 

replacing Error with Exception in the variable names allows for easier and 
quicker scanning of a line     

          private final Exception bindException;

         private final Exception connectException;

         private MockSocketImpl(Exception bindException, Exception 
connectException) {
             this.bindException = bindException;
             this.connectException = connectException;
         }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1854667093