On Tue, 26 Nov 2024 09:31:52 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:
> > You shouldn't need a mock SocketImpl. I assume you have this because the > > test is testing the Socket constructors mostly. > > @AlanBateman, existing tests are stressing both ctor **and** `connect()`. Okay, just a bit surprising to lump them into one test. One thing to consider is one test for the Socket.connect exception scenarios that is focused on checking the connect method throws as expected and the expected Socket state after connect fails. Lots of scenarios to test. A separate test could add to the tests for the Socket constructors, it would be a separate PR if you want. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22160#issuecomment-2500156051
