On Thu, 28 Nov 2024 09:12:58 GMT, Volkan Yazıcı <[email protected]> wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is unresolved.
>>
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Don't exceed 120 characters per line
> - Rework functional interfaces in tests
test/jdk/java/net/Socket/ConnectFailTest.java line 144:
> 142: }
> 143:
> 144: @SuppressWarnings("resource")
What is this SuppressWarnings for?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1862379919