On Thu, 28 Nov 2024 15:22:39 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Don't exceed 120 characters per line
>> - Rework functional interfaces in tests
>
> test/jdk/java/net/Socket/ConnectFailTest.java line 144:
>
>> 142: }
>> 143:
>> 144: @SuppressWarnings("resource")
>
> What is this SuppressWarnings for?
For IntelliJ's `'SocketChannel' used without 'try'-with-resources statement`
warning on `open()` method. Am I supposed to not suppress IDE warnings?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1862418705
