On Thu, 28 Nov 2024 16:26:55 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> For IntelliJ's `'SocketChannel' used without 'try'-with-resources statement` 
>> warning on `open()` method. Am I supposed to not suppress IDE warnings?
>
> Oh - OK - I see. That's fine. We usually don't suppress warnings in tests. 
> Maybe we should. On the other hand `@SuppressWarnings` is a two edged sword 
> as it can hide other issues if its scope is too large.

👍 Switched to a more fine-grained suppression.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1863192025

Reply via email to