On Mon, 20 Jan 2025 08:31:18 GMT, Volkan Yazıcı <[email protected]> wrote:
>> Adds `limiting()` factory methods to
>> `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input
>> in `HttpClient`. I would appreciate your input whether `discardExcess`
>> should be kept or dropped. I plan to file a CSR once there is an agreement
>> on the PR.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `HttpResponse` copyright year
test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 78:
> 76: @ParameterizedTest
> 77: @MethodSource("sufficientCapacities")
> 78: void testSuccessOnSufficientCapacity(HttpClient.Version version,
> boolean secure, long sufficientCapacity) throws Exception {
For this test method and the `testFailureOnInsufficientCapacity` method we
appear to be creating a server for each parameterized test. That can be
expensive. I think we can create the HTTP/HTTPS servers before hand (and have
the handlers registered) and use those servers in these test methods. We use a
similar strategy in several other tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923526897
