On Mon, 20 Jan 2025 08:31:18 GMT, Volkan Yazıcı <[email protected]> wrote:
>> Adds `limiting()` factory methods to
>> `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input
>> in `HttpClient`. I would appreciate your input whether `discardExcess`
>> should be kept or dropped. I plan to file a CSR once there is an agreement
>> on the PR.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `HttpResponse` copyright year
test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 148:
> 146:
> 147: // Issue the request
> 148: var request = HttpRequest
Are we intentionally not setting the HTTP version (being passed to this method)
on the request or the client?
test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 164:
> 162: HttpClient.Builder builder = HttpClient
> 163: .newBuilder()
> 164: .connectTimeout(Duration.ofSeconds(5));
Same comment about the usage of a timeout.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923549973
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923549276
