On Tue, 21 Jan 2025 11:25:09 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix `HttpResponse` copyright year
>
> test/jdk/java/net/httpclient/HttpResponseLimitingTest.java line 164:
> 
>> 162:         HttpClient.Builder builder = HttpClient
>> 163:                 .newBuilder()
>> 164:                 .connectTimeout(Duration.ofSeconds(5));
> 
> Same comment about the usage of a timeout.

I'd suggest to pass `.proxy(NO_PROXY)` too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1923890826

Reply via email to