On Mon, 17 Mar 2025 17:29:11 GMT, beppo-sturmtief <d...@openjdk.org> wrote:
> Hi, original filer here. I don't know how you handle such things here, but 24 > files changed seems somewhat excessive to me for this bug. Yes - I had the same impression at first but AFAICT most of the [superfluous] changes are due to the removal of the duplicate `Frame` class, that was included in the tests. That `Frame` class was a clone of the `Frame` class from WebSocket internal package, and therefore had the same bug. Volkan could have duplicated the changes into that class too - but instead chose to reuse the `Frame` class from the internal package (which is typically what we've been doing for HTTP/2 tests). I've been having mixed feelings about that. Now that we have strong encapsulation brought by the module system, opening up the class so that we can reuse it in tests has its merrit. But the price to pay is that all tests that use the dummy server now require the additionnal `@modules` clause. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24033#issuecomment-2733782218
