On Fri, 21 Mar 2025 11:23:51 GMT, Michael McMahon <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review feedback on naming in `Masker`
>>
>> `reset` -> `setMask`
>> `initGallopingMask` -> `initVectorMask`
>> `applyGallopingMask` -> `applyVectorMask`
>
> src/java.net.http/share/classes/jdk/internal/net/http/websocket/Frame.java
> line 145:
>
>> 143:
>> 144: /**
>> 145: * Positions the {@link #offset} at 0, which is needed for
>> vectorized masking, by masking necessary amount of bytes.
>
> Suggestion:
>
> * Applies up to 3 remaining from the previous pass bytes of the mask
> and
> * positions the {@link #offset} at 0, which is needed for vectorized
> masking,
> * by masking necessary amount of bytes.
@Michael-Mc-Mahon, I'm fine with the change, though doesn't this obsolete the
`by masking necessary amount of bytes` statement at the end?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24033#discussion_r2007400397
