On Wed, 2 Apr 2025 11:10:19 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hello Volkan, I think having the mention of ordering on the `id` field is
>> OK. I still find it confusing to have this sentence on the `label`:
>>
>>>
>>> As a result, compared to {@link #id}, this label does not give a total
>>> order among instances.
>>
>> To me, this feels odd because `label` being a `String` typically wouldn't
>> have been considered to be playing a role in ordering. Plus, in isolation,
>> it's not clear what ordering this talks about (Daniel did explain to me that
>> the `id` field is used in ordering of open connections. I haven't yet looked
>> deeper at that code to see where that happens).
>>
>> In any case, this is an internal class so if we do decide to use the current
>> proposed text, that's OK with me.
>
> I agree with Jaikiran: I would just remove the last sentence in this pargraph.
Implemented in 42ff0fc4a83cd33f1a35e4a2b3e7ce5c25ea39cc.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2028747158
