On Mon, 7 Apr 2025 08:27:38 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add -Djdk.httpclient.keepalive.timeout=120` to `@run`
test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 33:
> 31: *
> 32: * @comment `othervm` usage is intentional since this test uses
> `ForkJoinPool.commonPool()`
> 33: * @comment There is no guarantee that sequential requests will be
> executed immediately one after the other.
Thank you for all the updates so far Volkan. This is overall looking good to
me. One final nit about this comment. I think we can leave out a lot of this
text and just state something like:
@comment use a higher idle timeout to increase the chances of
the same connection being used for sequential HTTP requests
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030799061
