On Tue, 8 Apr 2025 19:27:17 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add `@implNote` to state that the built-in is always non-empty
test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 129:
> 127: throw new RuntimeException("failed closing server",
> serverException);
> 128: }
> 129: }
The message here seems to be wrong. Can we use something less exotic to start
the server too, and start it, for instance in the calling code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2037478237
