On Thu, 10 Apr 2025 13:52:52 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add `@implNote` to state that the built-in is always non-empty
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 129:
>
>> 127: throw new RuntimeException("failed closing server",
>> serverException);
>> 128: }
>> 129: }
>
> The message here seems to be wrong. Can we use something less exotic to start
> the server too, and start it, for instance in the calling code?
And also maybe log something after it's started - including the server
authority where it's listening at?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2037493825
