On Tue, 29 Apr 2025 13:32:46 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Add test for malformed push promise headers >> - Fix orphaned header consumer >> - Make HeaderDecoder constructor take a context parameter >> - Require ValidatingHeadersConsumer.context != null >> - Move test summary next to test bug number > > test/jdk/java/net/httpclient/http2/BadPushPromiseTest.java line 77: > >> 75: static final String MAIN_RESPONSE_BODY = "the main response body"; >> 76: >> 77: Http2TestServer server; > > Can we use HttpServerAdapters and HttpTestServer here please? It will make it > easier to create an equivalent test for HTTP/3. done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24569#discussion_r2066846339
