On Wed, 28 May 2025 12:05:20 GMT, Mikhail Yankelevich <myankelev...@openjdk.org> wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3 >> retries in case of invalid credentials supplied. >> >> This PR helps to resolve the bug and tests it with default and updated retry >> limit set via `jdk.httpclient.auth.retrylimit=1`. >> >> The test is green with tiers 1, 2, 3 and the test is stable. > > test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 34: > >> 32: * @build jdk.httpclient.test.lib.http2.Http2TestServer >> 33: * @run junit HttpClientRetryLimitTest >> 34: * @run junit/othervm -Djdk.httpclient.auth.retrylimit=1 >> HttpClientRetryLimitTest > > Do you think adding a retrylimit=0 would be beneficial too? This way every > scenario would be covered Added additional test case scenarios in 18bac9fa64f81110c2894f5f141e88ec5dc20b03 > test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 47: > >> 45: import java.net.http.HttpResponse; >> 46: >> 47: import static jdk.test.lib.Asserts.assertEquals; > > minor: Did you mean `import static > org.junit.jupiter.api.Assertions.assertEquals;` here, as you're using junit? Thank you for your review. The changes have been made in 18bac9fa64f81110c2894f5f141e88ec5dc20b03 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2114264448 PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2114259866
