On Wed, 28 May 2025 13:40:42 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 34: >> >>> 32: * @build jdk.httpclient.test.lib.http2.Http2TestServer >>> 33: * @run junit HttpClientRetryLimitTest >>> 34: * @run junit/othervm -Djdk.httpclient.auth.retrylimit=1 >>> HttpClientRetryLimitTest >> >> @dfuch, shall we test against zero and negative values too? (Both are >> accepted by `AuthenticationFilter` as valid.) > > We could. We could also throw in garbage to see what happens. New test scenarios have been added in https://github.com/openjdk/jdk/commit/18bac9fa64f81110c2894f5f141e88ec5dc20b03. We have default, positive, zero and negative values. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2114286157