On Thu, 29 May 2025 16:03:11 GMT, p-nima <d...@openjdk.org> wrote:

>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 66:
>> 
>>> 64:             };
>>> 65: 
>>> 66:             httpTestServer.addHandler(httpTestHandler, "/");
>> 
>> In the past, there has been occasions in CI where a test server received 
>> connections from a totally unrelated test running in parallel on the same 
>> host. To avoid such mishaps, we better salt the path a bit by, say, 
>> appending the class' simple name?
>
> Thanks for the catch - the class simple name has been appended in 
> 18bac9fa64f81110c2894f5f141e88ec5dc20b03

@p-nima, the handler still accepts all calls to `/`, you only salted the 
request URI. Would you mind doing the same in `httpTestServer.addHandler(...)` 
too, please? (You better create a `String requestPath` variable and use it both 
at the handler and the request.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2115448674

Reply via email to