On Fri, 7 Nov 2025 17:40:22 GMT, Daniel Fuchs <[email protected]> wrote:
>> Surprisingly if the QUIC handshake fails exceptionally, and
>> `-Djdk.httpclient.HttpClient.log=errors` is specified, the exception is not
>> logged. This change fixes that.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review feedback - request should fail
Doing this in a separate cleanup is fine by me. Note that one of the duplicates
can be easily removed already.
src/java.net.http/share/classes/jdk/internal/net/http/common/Log.java line 394:
> 392: public static void logError(Throwable t) {
> 393: if (errors()) {
> 394: logger.log(Level.INFO, "ERROR: " + t, t);
Suggestion:
logger.log(Level.INFO, "ERROR:", t);
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28196#pullrequestreview-3438579143
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2507114008
