On Sat, 8 Nov 2025 20:20:32 GMT, Daniel Jeliński <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback - request should fail
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/Log.java line
> 394:
>
>> 392: public static void logError(Throwable t) {
>> 393: if (errors()) {
>> 394: logger.log(Level.INFO, "ERROR: " + t, t);
>
> Suggestion:
>
> logger.log(Level.INFO, "ERROR:", t);
I'd rather not do that - this currently shows "ERROR: <exception-class>
<message>" followed by a newline and the stack trace. Having just "ERROR: " on
the line would look weird.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2509810870