On Thu, 20 Nov 2025 14:40:22 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> introduce HttpClientImplAccess instead of using Http3ConnectionAccess
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
> line 2116:
>
>> 2114: // that way when Http2Connection.isOpen() returns
>> false in that situation, then this
>> 2115: // getTerminationCause() will return a termination
>> cause.
>> 2116: terminate(Http2TerminationCause.forException(new
>> IOException("channel is not open")));
>
> Shouldn't we use `new ClosedChannelException()` here instead of `new
> IOException("channel is not open")`
Thank you for catching that. I had forgotten to update it after our discussion
few days back. I've done it now and the tier testing continues to pass with
this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2548209526
