On Mon, 24 Nov 2025 10:14:00 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/java/net/httpclient/http2/BurstyRequestsTest.java line 128: >> >>> 126: final Set<?> openedConnections = >>> HttpClientImplAccess.getOpenedConnections(client); >>> 127: assumeTrue(openedConnections != null, >>> 128: "skipping test against HttpClient of type " + >>> client.getClass().getName()); >> >> Please remove. The HttpClient will always be of the expected type, and >> keeping this code around will only make it harder to spot when the >> assumption no longer holds. > > Hello Daniel, my understanding is that the `HttpClient` default > implementation in the JDK will be `jdk.internal.net.http.HttpClientImpl`, but > if these tests are run against any other implementation of the `HttpClient` > then this test is going to fail to find that internal state. If that isn't a > practical concern, then I will go ahead and remove this skipping of the test. We don't have similar checks in any of the other whitebox tests, so I think we can safely assume that HttpClientImpl is the only implementation we test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2555747877
