On Tue, 4 Aug 2026 11:32:09 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java >> line 198: >> >>> 196: this.pushStreams = new HashSet<>(); >>> 197: is = socket.getInputStream(); >>> 198: os = socket.getOutputStream(); >> >> Why did we remove the `Buffered*` wrappers? > > Hello Volkan, buffering arbitrary amount of socket input/output didn't look > right to me. We would want the actual content to be available to the other > side without delays (and then the OS deal with the buffering). I was talking to Daniel J about this part of the change and he suggested that we retain the original buffered wrapping of the input/output streams at least until we run some experiments to verify that removing of this buffering isn't going to cause any unexpected delays when writing trivial amounts of data on a socket which doesn't have TCP_NODELAY set. I've updated the PR to retain the original code for these 2 streams. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32173#discussion_r3730179216
