On Tue, 1 Sep 2026 11:00:34 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve comments > > test/jdk/java/net/httpclient/IdleConnectionTimeoutReuseTest.java line 214: > >> 212: secure, >> 213: version, >> 214: () -> HttpTestServer.create(version, secure ? >> SSL_CONTEXT : null), > > Depending on the version (e.g if it's HTTP/3) you might want to create a > server that is HTTP/3 only. It will avoid testing HTTP/2 when you think you > are testing HTTP/3. OK - I see H3 uses HTTP_3_URI_ONLY - I missed that - sorry for the noise. > test/jdk/java/net/httpclient/IdleConnectionTimeoutReuseTest.java line 245: > >> 243: .host(server.getAddress().getAddress()) >> 244: .port(server.getAddress().getPort()) >> 245: .path(handlerPath) > > If the version is HTTP/3 you also might want to configure the request to use > HTTP/3 only. As it stands you are probably not testing HTTP/3 fully. I withdraw that comment too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3903852199 PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3903854738
