On Mon, 31 Aug 2026 08:43:52 GMT, Volkan Yazici <[email protected]> wrote:

>> I am not sure it's a good idea to do that. There should not be any server 
>> reserved streams if there is no client streams for HTTP/2, because push 
>> promises are supposed to be created while the main response stream is still 
>> open.
>
> How would you advise me to proceed with?
> 
> Note that `isIdle()` is used in other places than `shouldClose()`. I'm 
> inclined to have a single generic idleness check and have it employed 
> wherever necessary, instead of each caller rolling out its own 
> `streams.isEmpty() && numReservedClientStreams == 0 ...` checks.

Changed as requested in 7bc084a2047.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3901508419

Reply via email to