On Fri, 28 Aug 2026 12:00:57 GMT, Volkan Yazici <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Double-check idleness
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
> line 674:
>
>> 672: stateLock.lock();
>> 673: try {
>> 674: return finalStream() && isIdle();
>
> Note that previously we weren't checking against `numReservedServerStreams ==
> 0`, now we do.
I am not sure it's a good idea to do that. There should not be any server
reserved streams if there is no client streams for HTTP/2, because push
promises are supposed to be created while the main response stream is still
open.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3881596212
