On Thu, 19 Nov 2026 09:18:29 GMT, Matthias Baesken <[email protected]> wrote:

> Http3Connection.sendCancelPush method uses a byteBuffer, but seems to miss 
> the fip operation on the buffer.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The code change looks good, but could we have a small test for this? I believe 
H3PushCancel.java has a push promise handler that will trigger `sendPushCancel` 
by not running the acceptor. We'd need a scenario where the server only sends 
the push promise and then wait for the push promise to be cancelled. Sending 
the push promise only without opening the stream is easy, the method to do that 
is already on `HttpTestExchange` (`sendHttp3PushPromiseFrame`). You will 
probably need to add some mechanism so that the exchange can register some kind 
of listener to be invoked when `Http3ServerConnection.cancelPushReceived` is 
called, though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33968#issuecomment-7007238060

Reply via email to