On Thu, 19 Nov 2026 16:04:00 GMT, Matthias Baesken <[email protected]> wrote:

>> Http3Connection.sendCancelPush method uses a byteBuffer, but seems to miss 
>> the fip operation on the buffer.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add testCancelPushFrameSent Test

test/jdk/java/net/httpclient/http3/H3PushCancel.java line 421:

> 419:             assertTrue(cancelledId >= 0, "Server should receive 
> CANCEL_PUSH");
> 420:         }
> 421:     }

It might be a better idea to wait forever and let the test fail in jtreg 
timeout if the cancel is not recieved. This way we will get a thread dump when 
that happens.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33968#discussion_r4631477148

Reply via email to